Mod for polynomials over power series#277
Open
alexjbest wants to merge 1 commit into
Open
Conversation
Contributor
|
On Mon, Feb 18, 2019 at 10:21:05PM -0800, Alex J Best wrote:
Currently mod for polynomial rings is limited to base rings being fields and residue rings, seeing as series elem's are sort of like residue rings it would be nice to have mod for Poly{SeriesElems} also.
It seems like this works okay with this one line change, hopefully I can add some tests to this branch shortly to make this less of an issue and more of a PR.
You can view, comment on, or merge this pull request online at:
#277
There is a problem of mathematics...
mod has to work over any field
mod can work if the divisor is monic (well, leading coeff a unit)
or if a miracle happens and all divisions by the leading coeff "just
work".
What is the intended behaviour when that fails?
Currently we have two things
Over Z: you get a remainder which is too large
Over Z/nZ: you get an exception about a failed division
What is your specification?
Greetings
Claus
… -- Commit Summary --
* define mod for series elems
-- File Changes --
M src/generic/Poly.jl (2)
-- Patch Links --
https://github.com/Nemocas/AbstractAlgebra.jl/pull/277.patch
https://github.com/Nemocas/AbstractAlgebra.jl/pull/277.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#277
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently mod for polynomial rings is limited to base rings being fields and residue rings, seeing as series elem's are sort of like residue rings it would be nice to have mod for Poly{SeriesElems} also.
It seems like this works okay with this one line change, hopefully I can add some tests to this branch shortly to make this less of an issue and more of a PR.